Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix depth cam #814

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Hotfix depth cam #814

wants to merge 2 commits into from

Conversation

pengzhenghao
Copy link
Member

What changes do you make in this PR?

  • Please describe why you create this PR

resolve #813

  1. Add test to assert depth img in range [0,255] first

Checklist

  • I have merged the latest main branch into current branch.
  • I have run bash scripts/format.sh before merging.
  • Please use "squash and merge" mode.

@QuanyiLi
Copy link
Member

The old depth camera also applies a log to the depth value. If you want to completely reproduce the old depth results, you can take the depth_convert.glsl as reference

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

HOTFIX REQUIRED: recent depth image update breaks SimGen
2 participants
@pengzhenghao @QuanyiLi