Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firewalls in maintenance reconciliation #43

Merged
merged 17 commits into from
May 29, 2024
Merged

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Aug 31, 2023

This PR implements the set roll for firewalls when a shorthand OS image name is being used and the maintenance reconciliation was triggered.

@Gerrit91 Gerrit91 marked this pull request as ready for review September 1, 2023 09:04
@Gerrit91 Gerrit91 requested a review from a team as a code owner September 1, 2023 09:04
@majst01
Copy link
Contributor

majst01 commented Sep 4, 2023

Deployment does not change and therefor the imagecache will not be asked to fetch the newest image.

It should depend on the gardener maintain reconciliation and trigger firewall roll during the maintenance window

@Gerrit91 Gerrit91 changed the title Fix OS image update not detected for versions without suffix.. Update firewalls in maintenance reconciliation Apr 29, 2024
@Gerrit91
Copy link
Contributor Author

Gerrit91 commented May 2, 2024

Looks like this finally works now.

controllers/deployment/controller.go Outdated Show resolved Hide resolved
@Gerrit91 Gerrit91 requested a review from majst01 May 29, 2024 09:13
@Gerrit91 Gerrit91 merged commit c82cbc4 into main May 29, 2024
2 checks passed
@Gerrit91 Gerrit91 deleted the fix-os-image-update branch May 29, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants