Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First part implementation of shoot migration for firewalls #308

Merged
merged 54 commits into from
Oct 24, 2023

Conversation

Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented May 2, 2023

References #306.

This implementation will resolve the issue that two firewalls will appear after the shoot migration.

However, the firewall-controller looses the connection to the API server because the endpoint has changed and it has no fitting credentials. For now, this requires manual action and update the ca, the token and the API endpoint in the firewall's seed kubeconfig to the freshly created service account secret.

The PR also cleans up old migration code used in the worker controller for migrating to the firewall-controller-manager.

The compatibility for the old firewall-controller v1 is now dropped. Make sure that all firewall images that still ship with firewall-controller v1 are set to deprecated in the metal-api and that all firewalls are migrated to the firewall-controller-manager and running firewall-controller v2. Clusters that still use deprecated firewall images shipping must update to a current firewall image as the recreation of a firewall with an old image is not possible anymore.

@Gerrit91 Gerrit91 force-pushed the shoot-migration-for-firewalls branch 6 times, most recently from f1d3f5d to d68cc28 Compare May 4, 2023 07:52
@Gerrit91 Gerrit91 force-pushed the shoot-migration-for-firewalls branch from d68cc28 to 62296db Compare May 5, 2023 06:32
@Gerrit91 Gerrit91 marked this pull request as ready for review June 27, 2023 13:25
@Gerrit91 Gerrit91 requested a review from a team as a code owner June 27, 2023 13:25
@Gerrit91 Gerrit91 changed the title Implement shoot migration for firewall-controller-manager. First part implementation of shoot migration for firewalls Oct 12, 2023
Copy link
Contributor

@majst01 majst01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of changes, looks good, but testing is required

@Gerrit91 Gerrit91 merged commit d03bb57 into master Oct 24, 2023
2 checks passed
@Gerrit91 Gerrit91 deleted the shoot-migration-for-firewalls branch October 24, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants