-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First part implementation of shoot migration for firewalls #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gerrit91
force-pushed
the
shoot-migration-for-firewalls
branch
6 times, most recently
from
May 4, 2023 07:52
f1d3f5d
to
d68cc28
Compare
Gerrit91
force-pushed
the
shoot-migration-for-firewalls
branch
from
May 5, 2023 06:32
d68cc28
to
62296db
Compare
Gerrit91
changed the title
Implement shoot migration for firewall-controller-manager.
First part implementation of shoot migration for firewalls
Oct 12, 2023
This was referenced Oct 12, 2023
majst01
reviewed
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of changes, looks good, but testing is required
majst01
approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References #306.
This implementation will resolve the issue that two firewalls will appear after the shoot migration.
However, the firewall-controller looses the connection to the API server because the endpoint has changed and it has no fitting credentials. For now, this requires manual action and update the
ca
, thetoken
and the API endpoint in the firewall's seed kubeconfig to the freshly created service account secret.The PR also cleans up old migration code used in the worker controller for migrating to the firewall-controller-manager.