Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solving #81 #83

Merged
merged 2 commits into from
Sep 4, 2018
Merged

Solving #81 #83

merged 2 commits into from
Sep 4, 2018

Conversation

diegonvs
Copy link
Collaborator

No description provided.

@diegonvs diegonvs changed the base branch from master to develop August 28, 2018 22:43
@diegonvs diegonvs changed the title Make metal-storage compatible with SSR WIP: Make metal-storage compatible with SSR Aug 28, 2018
@jbalsas
Copy link
Contributor

jbalsas commented Aug 29, 2018

Hey @diegonvs, I think this just needs running npm run format to fix the formatting issues. Is this still WIP? Is this all we need for SSR? To do nothing? 😂

@diegonvs diegonvs changed the title WIP: Make metal-storage compatible with SSR Solving #81 Aug 29, 2018
@diegonvs
Copy link
Collaborator Author

Hey @jbalsas, yes.

cc @ipeychev , it works for you? I've understood correctly the problem?

@diegonvs
Copy link
Collaborator Author

diegonvs commented Aug 29, 2018

I think that the commit name was not the most appropriate 😂 I'm accepting suggestions

@diegonvs
Copy link
Collaborator Author

We need take some caution by doing this because: metal/metal.js#359

@jbalsas jbalsas merged commit f8c9a8d into metal:develop Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants