Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add script to execute styles in order | Fixes #383 #387

Closed
wants to merge 1 commit into from

Conversation

diegonvs
Copy link
Contributor

No description provided.

@diegonvs diegonvs changed the base branch from master to develop July 24, 2018 13:51
@diegonvs
Copy link
Contributor Author

#383

@jbalsas
Copy link
Contributor

jbalsas commented Jul 24, 2018

Hey guys! have you tried this in IE11? Based on our tests, this might fail to fire the proper load events there...

At least that’s what we observed when applied to senna on IE11. Could you check that?

@antonio-ortega, could you share here the portal LPS we were trying to fix with this?

@antonio-ortega
Copy link

Hi @diegonvs,

I've tried your solution and it is not working. This is the first idea that came up to my mind when I started working on this and the problem with this case is we get stuck in the first iteration because apparently load event is not fired so we don't continue looping.

The Portal LPS is LPS-83765.

Thanks,

@matuzalemsteles
Copy link
Contributor

hey guys, Diego is seeing some other possibilities to listen when a new style was loaded on the page, it should bring more information to afternoon about some possibilities that we can go.

@diegonvs
Copy link
Contributor Author

diegonvs commented Jul 25, 2018

Some updates from yesterday: Now i'm able to reproduce this and in last days i'm trying to write a solution taking as base that styleElement.sheet.cssRules is only populated when the file is completely loaded to avoid listening load event.

@diegonvs diegonvs closed this Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants