🌱 E2E: Use kind instead of minikube #2276
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
metal3-io-bot
added
the
size/L
| @@ -1,6 +1,6 @@ | |||
| HTTP_PORT=6180 | |||
| PROVISIONING_IP=192.168.222.199 | |||
| CACHEURL=http://192.168.222.199/images | |||
| IRONIC_FAST_TRACK=true | |||
There was a problem hiding this comment.
is the removal of IRONIC_FAST_TRACK intended?
There was a problem hiding this comment.
I removed it to reduce the differences between 0.8 and main. Removing it does not disable fast track because it defaults to true in the ironic-image
lentzi90
force-pushed
the
lentzi90/e2e-kind-release-0.8
branch
from
5c0abe2 to
0825cfc
Compare
Minikube is having troubles starting sometimes. It was nice to work with since the VM could easily be attached to the same network as the BMH VMs, but it is possible to work around that also with kind. Signed-off-by: Lennart Jern <[email protected]>
lentzi90
force-pushed
the
lentzi90/e2e-kind-release-0.8
branch
from
0825cfc to
63c6cc5
Compare
| @@ -3,7 +3,6 @@ | |||
| REPO_ROOT=$(dirname "${BASH_SOURCE[0]}")/.. | |||
| cd "${REPO_ROOT}" || exit 1 | |||
|
|
|||
| minikube delete | |||
There was a problem hiding this comment.
Why don't we delete the kind cluster here anymore?
What this PR does / why we need it:
Minikube is having troubles starting sometimes.
It was nice to work with since the VM could easily be attached to the same network as the BMH VMs, but it is possible to work around that also with kind.
This is a manual backport of (parts of) #2222
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #