Add Stop and Clear methods + some enhancements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- main branch must be protected now - we do tests on pull requests
Context is not necessary here. A simple chan + goroutine is enough to check timeout.
- `Stop()` can now stop the pipeline - `Clear()` drops all elements in the pipeline, it can be useful in some situation
- we now get the entire logs in a buffer (easy to check content) - some tests needs now to wait a bit as we now try to ensure that a state is set in synchroneous mode
Fyne continues to maintain the compatibilty with Go 1.14. Even if it's not the case for Go-GST, we prefer to follow the rule. Note that contributors can update go.mod using: `go mod tidy -compat="1.14"`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop()andClear()methods