Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: t4lz <[email protected]>
  • Loading branch information
Razz4780 and t4lz authored Jan 23, 2025
1 parent 58adfee commit 05792a7
Showing 1 changed file with 5 additions and 5 deletions.
10 changes: 5 additions & 5 deletions mirrord/config/src/target.rs
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche
/// ```
///
/// The setup above will result in a session targeting the `bear-pod` Kubernetes pod
/// in the user's default namespace. Target container will be chosen by mirrord.
/// in the user's default namespace. A target container will be chosen by mirrord.
///
/// Shortened setup with target container:
///
Expand All @@ -105,7 +105,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche
/// }
/// ```
///
/// Setup above will result in a session targeting the `bear-pod-container` container
/// The setup above will result in a session targeting the `bear-pod-container` container
/// in the `bear-pod` Kubernetes pod in the user's default namespace.
///
/// Complete setup:
Expand All @@ -122,7 +122,7 @@ fn make_simple_target_custom_schema(gen: &mut SchemaGenerator) -> schemars::sche
/// }
/// ```
///
/// Setup above will result in a session targeting the `bear-pod-container` container
/// The setup above will result in a session targeting the `bear-pod-container` container
/// in the `bear-pod` Kubernetes pod in the `bear-pod-namespace` namespace.
#[derive(Serialize, Deserialize, Clone, Eq, PartialEq, Hash, Debug)]
#[serde(deny_unknown_fields)]
Expand Down Expand Up @@ -154,7 +154,7 @@ pub struct TargetConfig {
///
/// Namespace where the target lives.
///
/// Defaults to Kubernetes user's default namespace (defined in Kubernetes context).
/// Defaults to the Kubernetes user's default namespace (defined in Kubernetes context).
#[serde(skip_serializing_if = "Option::is_none")]
pub namespace: Option<String>,
}
Expand Down Expand Up @@ -259,7 +259,7 @@ pub enum Target {
Pod(pod::PodTarget),

/// <!--${internal}-->
/// [Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work).
/// [Argo Rollout](https://argoproj.github.io/argo-rollouts/#how-does-it-work).
Rollout(rollout::RolloutTarget),

/// <!--${internal}-->
Expand Down

0 comments on commit 05792a7

Please sign in to comment.