Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: added missing german stations #483

Merged

Conversation

SiddharthKhatsuriya
Copy link
Contributor

Added missing German weather station from DWD database.

Note: when comparing the DWD databse and meteostat there were 520+ stations missing, but accordign to the find_duplicates logic ~180 of these missing stations are not getting added because they are probably too close to each other. I have added scripts\germany\duplicate_stations_reported.json which shows all the stations that are considered duplicate.

@clampr clampr added the enhancement New feature or request label Aug 24, 2022
@peterhaufler
Copy link

@clampr I found this pull request after realizing, that DWD stations are missing in the Meteostat system. Has this pull request been denied or only been forgotten? What would it take to merge this pull request and close the DWD station gap in the Meteostat system?

@clampr
Copy link
Member

clampr commented May 10, 2023

First, I want to appologize for taking so much time to review this PR. Great job @SiddharthKhatsuriya 🙂

I added the ISO codes for the regions (Bundesländer) and the time zone. Also fixed the pipeline errors.

@peterhaufler could you be so kind and review the changes? I'd like to know if it roughly matches the discrepancy that you guys have identified. Obviously, we're still missing the stations that have been flagged as duplicates. Will create a follow-up issue for these stations.

@peterhaufler
Copy link

@clampr thanks for taking care for this pull request :) On my side, I just realised, that for one of our weather insurance contracts, there was a much nearer weather station available "Bochum" to the insured location, than the one provided by Meteostat. I found that station in this pull request (id LH10Y).
So I am sure that this will be a good improvement, but I did no systematic check, if there are still stations missing.
But of cause if there are still stations flagged as duplicates, that are not duplicates and will not be added with this pull request, we are very interested on a follow up so at the end all German stations are in the system.

@clampr clampr merged commit 2666df9 into meteostat:master May 12, 2023
@clampr
Copy link
Member

clampr commented May 12, 2023

Follow-up issue created (#489).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants