-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KDVH migration package #30
Conversation
|
Flag definitions: |
Related to point 4, sorry for the confusion! I was specifically asking since in lard/kdvh_importer/data_functions.go Lines 28 to 39 in 648d5f8
But I'm with you, it doesn't make sense to dump them 👌 |
Hmm, could this be in the case of blob data? |
cc7a951
to
40b69e6
Compare
@Lun4m Do you think there would be a point in removing the indices while importing? I would think it's maybe redundant with In any case we should probably run |
I can provide a list of which stnr / tables are defined as closed |
Thanks, but I don't think that's necessary, we can fetch it from stinfosys |
…y to pgx.CopyFromRows
Ah, I forgot to drop the indices. Edit: Done! |
This PR tackles the first part of issue #14.
I adapted some scripts originally written by Ketil for ODA to dump tables from KDVH and import them into LARD. Almost happy with the code...
Things I'm still not 100% sure about:
T_MONTH_INTERPOLATED
andT_DIURNAL_INTERPOLATED
, probably I need to connect to KDVH directly?blobData
used for non-scalar parameters (KLOBS
for example)?data_functions.go
we do a lot of postprocessing that I haven't touched since I don't really understand it. My main concern is with the insertion of "null" values (i.e.-32767
, etc.), are these used somewhere downstream? Otherwise I might simply drop them, since our schema can handle real NULLs.@ketilt, do you have any insight regarding these points? Or comments about the code, if you have time to take a look at it?
Still left to do:
CorrKDVH
field, since original and corrected have the same valuecontrolinfo
anduseinfo
are correct