Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulkfraction engine for pyaeroval #1458

Draft
wants to merge 25 commits into
base: main-dev
Choose a base branch
from
Draft

Bulkfraction engine for pyaeroval #1458

wants to merge 25 commits into from

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Dec 13, 2024

Change Summary

Tries to implement a way of evaluating bulk variables and fraction. Is needed for the "EC for GP revision" project

Checklist

  • Start with a draft-PR
  • The PR title is a good summary of the changes
  • PR is set to AeroTools and a tentative milestone
  • Documentation reflects the changes where applicable
  • Tests for the changes exist where applicable
  • Tests pass locally
  • Tests pass on CI
  • At least 1 reviewer is selected
  • Make PR ready to review

@dulte dulte added the enhancement ✨ New feature or request label Dec 13, 2024
@dulte dulte added this to the m2025-02 milestone Dec 13, 2024
@dulte dulte self-assigned this Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

Attention: Patch coverage is 62.17949% with 59 lines in your changes missing coverage. Please review.

Project coverage is 78.38%. Comparing base (23809dc) to head (4e2a182).
Report is 349 commits behind head on main-dev.

Files with missing lines Patch % Lines
pyaerocom/aux_var_helpers.py 10.81% 33 Missing ⚠️
pyaerocom/aeroval/bulkfraction_engine.py 79.38% 20 Missing ⚠️
pyaerocom/aeroval/obsentry.py 69.23% 4 Missing ⚠️
pyaerocom/aeroval/experiment_processor.py 50.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           main-dev    #1458      +/-   ##
============================================
- Coverage     78.87%   78.38%   -0.49%     
============================================
  Files           136      140       +4     
  Lines         20863    21289     +426     
============================================
+ Hits          16455    16687     +232     
- Misses         4408     4602     +194     
Flag Coverage Δ
unittests 78.38% <62.17%> (-0.49%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator Author

@dulte dulte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

99f5402 This commit changes alot, and needs to be better tested/looked over before used in ECforGP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant