Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the correct way of setting filters #24

Merged
merged 1 commit into from
Jan 10, 2024
Merged

Conversation

dulte
Copy link
Collaborator

@dulte dulte commented Jan 4, 2024

Fixed the problem we discussed with the filters

@heikoklein
Copy link
Member

Some tests should maybe changed, too, i.e. change https://github.com/metno/pyaro-readers/blob/22ca00ae1bc564a927b9fc757d31c44ffca355ad/tests/test_AERONETSDATimeSeriesReader.py#L119C9-L121C73

sfilter = pyaro.timeseries.filters.get("stations", exclude=["Cuiaba"])
        with engine.open(
            self.file, filters=[sfilter], tqdm_desc="test_stationfilter"

to

        with engine.open(
            self.file, filters={"stations": {"exclude": ["Cuiaba"]}}, tqdm_desc="test_stationfilter"

Copy link
Member

@jgriesfeller jgriesfeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this. All good.

@jgriesfeller jgriesfeller merged commit e5363fc into main-dev Jan 10, 2024
4 checks passed
@jgriesfeller jgriesfeller deleted the filter_fix branch January 10, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants