fix: (-some-pred []) should return false

Previously, it was returning false in cljs but true in clj. Now it returns false in both. This is in line with (or) returning nil and (and) returning true in clojure. fixes #751
metosin · Aug 28, 2024 · 7704849 · 7704849
1 parent 50da02b
commit 7704849
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/src/malli/impl/util.cljc b/src/malli/impl/util.cljc
@@ -60,7 +60,7 @@
                    (fn [x#] (~c (p# x#) (q# x#))))]
        `(fn ~f [~preds]
           (case (count ~preds)
-            0 (constantly true)
+            0 (constantly (boolean (~c)))
             1 (first ~preds)
             ~@cases
             ~else)))))

diff --git a/test/malli/util_test.cljc b/test/malli/util_test.cljc
@@ -946,7 +946,10 @@
          (is (true? ((miu/-some-pred tf) nil)))
          (is (true? ((miu/-some-pred ft) nil)))
          (is (false? ((miu/-some-pred ff) nil)))
-         (is (true? ((miu/-some-pred tt) nil)))))))
+         (is (true? ((miu/-some-pred tt) nil))))
+       (testing "empty inputs"
+         (is (true? ((miu/-every-pred []) :anything)))
+         (is (false? ((miu/-some-pred []) :anything)))))))
 
 (deftest explain-data-test
   (let [schema (m/schema [:map [:a [:vector [:maybe :string]]]])