Merge pull request #1101 from metosin/fix/some-pred

fix: (-some-pred []) should return false
metosin · Aug 28, 2024 · b91fc18 · b91fc18
2 parents 50da02b + 20d0efd
commit b91fc18
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/clojure.yml b/.github/workflows/clojure.yml
@@ -102,8 +102,6 @@ jobs:
         uses: DeLaGuardo/setup-clojure@master
         with:
           cli: latest
-          # bb: latest
-      - name: Download bb master
-        run: bash <(curl -s https://raw.githubusercontent.com/babashka/babashka/master/install) --version 0.8.157-SNAPSHOT
+          bb: latest
       - name: Run tests
         run: bb test-bb
diff --git a/src/malli/impl/util.cljc b/src/malli/impl/util.cljc
@@ -60,7 +60,7 @@
                    (fn [x#] (~c (p# x#) (q# x#))))]
        `(fn ~f [~preds]
           (case (count ~preds)
-            0 (constantly true)
+            0 (constantly (boolean (~c)))
             1 (first ~preds)
             ~@cases
             ~else)))))

diff --git a/test/malli/util_test.cljc b/test/malli/util_test.cljc
@@ -946,7 +946,10 @@
          (is (true? ((miu/-some-pred tf) nil)))
          (is (true? ((miu/-some-pred ft) nil)))
          (is (false? ((miu/-some-pred ff) nil)))
-         (is (true? ((miu/-some-pred tt) nil)))))))
+         (is (true? ((miu/-some-pred tt) nil))))
+       (testing "empty inputs"
+         (is (true? ((miu/-every-pred []) :anything)))
+         (is (false? ((miu/-some-pred []) :anything)))))))
 
 (deftest explain-data-test
   (let [schema (m/schema [:map [:a [:vector [:maybe :string]]]])