Fix issue #775 #894
Closed
Fix issue #775 #894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually it looks like this doesn't solve the problem for me. Maybe that's why #774 was in draft. :) I'm closing in on a test case that demonstrates the problem at a higher level, so hopefully I can figure out a real fix from that. No need to review this yet. |
|
I wasn't able to repro this in a simple test after all. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I also ran into issue #775 and saw that there was a draft PR (#774) to fix it but wasn't sure what the status of that was. A similar approach seemed to fix it, so here's a non-draft PR. Thanks @piotr-yuxuan for the shoulders to stand on!