1040 add acu db alarm #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RamilGaripov
approved these changes
Dec 18, 2023
leite08
commented
Dec 18, 2023
Comment on lines
-336
to
-349
| const storageMetric = dbCluster.metricFreeLocalStorage(); | ||
| const storageAlarm = storageMetric.createAlarm( | ||
| this, | ||
| `${dbClusterName}FreeLocalStorageAlarm`, | ||
| { | ||
| threshold: mbToBytes(250), | ||
| evaluationPeriods: 1, | ||
| comparisonOperator: | ||
| cloudwatch.ComparisonOperator.LESS_THAN_OR_EQUAL_TO_THRESHOLD, | ||
| treatMissingData: cloudwatch.TreatMissingData.NOT_BREACHING, | ||
| } | ||
| ); | ||
| alarmAction && storageAlarm.addAlarmAction(alarmAction); | ||
| alarmAction && storageAlarm.addOkAction(alarmAction); |
There was a problem hiding this comment.
Removed b/c it's not applicable to Aurora serverless v2 - link, search for FreeLocalStorage.
@RamilGaripov good catch! I was going to add a comment about it but forgot, sorry. Added one now, but yeah, not applicable to Aurora serverless v2. |
Orta21
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://github.com/metriport/metriport-internal/issues/1040
Dependencies
Related:
Description
Add ACU DB alarm.
Upgraded CDK to the same version of OSS to have access to the ACU metric.
Testing
stagingRelease Plan