Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1734 adding config and maintenance window #56

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

thomasyopes
Copy link

Ref: #1734

Dependencies

Description

  • Adding config + maintenance window

Release Plan

  • Merge this

Copy link
Member

@leite08 leite08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • ticket number on the description w/ link to the actual ticket, so GH can link them (creates a record on the ticket itself)
  • the dependency is upstream to this one, i.e., this PR can only be merged when the dependency is merged too
  • release plan to indicate merging upstream and then this one

@leite08
Copy link
Member

leite08 commented May 8, 2024

@thomasyopes I just realized the FHIRServer's configs are not pointing to internal! 🤦

See how it should look like (OSS): https://github.com/metriport/metriport/tree/develop/packages/infra/config

How it looks like on this repo: https://github.com/metriport/fhir-server/tree/develop/infra/config

Let's add a fix for this as part of this PR?

There'll be still something outstanding, which is to make CICD to use those configs, so we don't need them b64'd on GH secrets, like we do for OSS: https://github.com/metriport/metriport-internal/issues/1760

@thomasyopes thomasyopes marked this pull request as draft May 20, 2024 18:27
@thomasyopes thomasyopes changed the title feat(infra): adding config and maintenance window 1734 adding config and maintenance window May 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants