Remove unnecessary timestamp columns from models #219
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you tested how does this affect kalibro_client? |
|
It will be necessary to change the processor entities to not expect those columns. We just need to make sure we release a new kalibro_client stable version together with the next stable processor version. |
Remove the timestamp columns from the KalibroModule, ModuleResult, MetricResult and ProcessingTime models. They were not used by anything, but needed to be populated and inserted in millions of records. This will require a KalibroClient change in the future.
danielkza
force-pushed
the
remove_timestamps
branch
from
5a3fc51
to
02b33ac
Compare
|
Rebased to master. Ping @mezuro/core. |
|
I'm waiting for #225 to get merged before this, so the release of 1.3.3 is easier. |
|
Ok for me 👍 |
|
This probably should go into a new major version. |
|
A question came to me right now: do we have any reference if this has any impact on insertion time? Or select times? Or DB size in disk? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the timestamp columns from the KalibroModule, ModuleResult,
MetricResult and ProcessingTime models. They were not used by anything,
but needed to be populated and inserted in millions of records.
This will require a KalibroClient change in the future.