-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update rails #231
Open
do-you-dare
wants to merge
32
commits into
master
Choose a base branch
from
update_rails
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Update rails #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
What do you think about removing Travis' build for those older breaking version? |
What is the status on WIP acceptance test? |
Sorry, for a moment I forgot I wip-ed them. So, only one of them is passing. The |
This gem eases the job of upgrading the application gems.
It required activesupport ~>4.2, while rails 5 requires 5.0.0.1.
The changes on Rails break some of the code, and the tests with them, that's why they are pending.
As of rails 5, Active Record Models inherit from ApplicationRecord by default.
The rails 5 update task overwrites the routes configuration.
As of Rails 5, jobs inherit from ApplicationJob, not ActiveJob::Base.
Activesupport doesn't support rubies 2.2 and 2.1.5, and it makes no sense to test against something we know that won't and shouldn't pass.
do-you-dare
force-pushed
the
update_rails
branch
from
December 1, 2016 23:59
1ce7a60
to
2b6a8a9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates rails to Rails 5. The ci checks will fail for rubies 2.0 and 2.1.5, since rails doesn't support them anymore.