Versions of Dependencies updated (#92)

* versions of dependencies updated in pom.xml and removed used import fro jsonschemavalidationtest file * updated command in docker compose file comments and updated docker compose command in the maven workflow file
mfaisalkhatri · Nov 28, 2024 · a8eb1eb · a8eb1eb
1 parent 946401c
commit a8eb1eb
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 11 deletions.
diff --git a/.github/workflows/maven.yml b/.github/workflows/maven.yml
@@ -24,13 +24,13 @@ jobs:
           cache: maven
 
       - name: Start restful booker service
-        run: docker-compose -f ${{ github.workspace }}/docker-compose-restfulbooker.yml up -d
+        run: docker compose -f ${{ github.workspace }}/docker-compose-restfulbooker.yml up -d
 
       - name: Build with Maven and run tests
         run: mvn clean install
 
       - name: Stop restful booker service
-        run: docker-compose -f ${{ github.workspace }}/docker-compose-restfulbooker.yml down --remove-orphans
+        run: docker compose -f ${{ github.workspace }}/docker-compose-restfulbooker.yml down --remove-orphans
 
       - name: Test Report
         uses: dorny/test-reporter@v1

diff --git a/docker-compose-restfulbooker.yml b/docker-compose-restfulbooker.yml
@@ -1,6 +1,6 @@
-# To execute this docker-compose yml file use `docker-compose -f docker-compose-restfulbooker.yml up -d`
+# To execute this docker-compose yml file use `docker compose -f docker-compose-restfulbooker.yml up -d`
 # Add the `-d` flag at the end for detached execution
-# To stop the execution, hit Ctrl+C, and then `docker-compose -f docker-compose-restfulbooker.yml down`
+# To stop the execution, hit Ctrl+C, and then `docker compose -f docker-compose-restfulbooker.yml down`
 version: "3"
 services:
   restful-booker:

diff --git a/pom.xml b/pom.xml
@@ -14,16 +14,16 @@
         <rest-assured.version>5.5.0</rest-assured.version>
         <hamcrest-all.version>1.3</hamcrest-all.version>
         <json-simple.version>1.1.1</json-simple.version>
-        <lombok.version>1.18.34</lombok.version>
-        <jackson-databind.version>2.17.2</jackson-databind.version>
+        <lombok.version>1.18.36</lombok.version>
+        <jackson-databind.version>2.18.2</jackson-databind.version>
         <org-json.verion>20240303</org-json.verion>
-        <data-faker.version>2.3.1</data-faker.version>
+        <data-faker.version>2.4.2</data-faker.version>
         <log4jcore.version>3.0.0-beta2</log4jcore.version>
         <log4japi.version>3.0.0-beta2</log4japi.version>
         <json-schema-validator.version>5.5.0</json-schema-validator.version>
-        <allure.version>2.28.1</allure.version>
-        <awaitility.version>4.2.1</awaitility.version>
-        <commons-lang3.version>3.15.0</commons-lang3.version>
+        <allure.version>2.29.0</allure.version>
+        <awaitility.version>4.2.2</awaitility.version>
+        <commons-lang3.version>3.17.0</commons-lang3.version>
         <aspectj.version>1.9.22.1</aspectj.version>
         <maven-compiler-plugin.version>3.13.0</maven-compiler-plugin.version>
         <maven-surefire-plugin.version>3.3.1</maven-surefire-plugin.version>

diff --git a/src/test/java/com/restfulbooker/JsonSchemaValidationTest.java b/src/test/java/com/restfulbooker/JsonSchemaValidationTest.java
@@ -17,7 +17,6 @@
 import io.qameta.allure.SeverityLevel;
 import io.qameta.allure.Story;
 import io.restassured.module.jsv.JsonSchemaValidator;
-import org.testng.annotations.BeforeTest;
 import org.testng.annotations.Test;
 
 /**