Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Paid_hours should be renamed to fee #6

Closed
hbruch opened this issue Mar 9, 2020 · 3 comments · Fixed by #12
Closed

Paid_hours should be renamed to fee #6

hbruch opened this issue Mar 9, 2020 · 3 comments · Fixed by #12

Comments

@hbruch
Copy link
Member

hbruch commented Mar 9, 2020

Values should be ‚no/yes/opening_hours like string‘
That is to comply withOSM tagging and not to introduce a new scheme.

For parkings where charge is know, this may be provided as well (see OSM wiki)
@hbruch
Copy link
Member Author

hbruch commented May 16, 2020

Fixed via df86b24

@hbruch hbruch closed this as completed May 16, 2020
@hbruch
Copy link
Member Author

hbruch commented May 16, 2020

Reopening as fix was applied only partially, i.e. thingsboard-to-parkapi was not fixed.

@hbruch hbruch reopened this May 16, 2020
@hbruch
Copy link
Member Author

hbruch commented Sep 21, 2020

@leonardehrenfried Could you please check this one? Your PR uses fee_hours but we still use paidHours/paid_hours.

@hbruch hbruch mentioned this issue Nov 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Robustness fixes mfdz/thingsboard-to-parkapi
1 participant
@hbruch