Robustness fixes #12
Merged
Robustness fixes #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is a great change, thanks! It's good to merge. I'm wondering about the roll out of the change. It would require changing the frontend, too, in order to use the renamed fields. What's the priority for this? |
|
That shouldn't be a to great change, as I left coords/lat coords/lng in for now. Further: paid_hours currently is currently even not in the API, so for the client, nothing would change. |
|
You're right. I overlooked that fact that opening_hours is already named correctly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some API conformance issues and makes the script a bit more robust, if no data can be retrieved.
Fixes #9. Fixes #6. Fixes #5.