Indicate infinite capacitance for zero reactance (#213)

mfikes · Jan 28, 2024 · 3ac0af7 · 3ac0af7
1 parent c7160a0
commit 3ac0af7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/Impedance Converter/Impedance Converter/ViewModel.swift b/Impedance Converter/Impedance Converter/ViewModel.swift
@@ -413,7 +413,7 @@ class ViewModel: ObservableObject, Codable {
         get {
             switch circuitMode {
             case .series:
-                return -1 / (omega * reactance)
+                return reactance.isZero ? Double.infinity : -1 / (omega * reactance)
             case .parallel:
                 return susceptance / omega
             }
@@ -435,7 +435,7 @@ class ViewModel: ObservableObject, Codable {
             case .series:
                 return reactance / omega
             case .parallel:
-                return -1 / (susceptance * omega)
+                return susceptance.isZero ? Double.infinity : -1 / (susceptance * omega)
             }
         }
         set {

diff --git a/Impedance Converter/Impedance ConverterTests/ViewModelTests.swift b/Impedance Converter/Impedance ConverterTests/ViewModelTests.swift
@@ -344,6 +344,12 @@ class ReactiveParametersTests: ViewModelTestBase {
         viewModel.inductance = newInductance
         XCTAssertEqual(viewModel.reactance, newInductance * viewModel.omega)
     }
+
+    func testInductanceWithZeroSusceptance() {
+        viewModel.susceptance = 0
+        viewModel.circuitMode = .parallel
+        XCTAssertEqual(viewModel.inductance, Double.infinity)
+    }
 
     // Testing Capacitance
     func testCapacitance() {
@@ -358,6 +364,12 @@ class ReactiveParametersTests: ViewModelTestBase {
         viewModel.capacitance = newCapacitance
         XCTAssertEqual(viewModel.susceptance, newCapacitance * viewModel.omega)
     }
+
+    func testCapacitanceWithZeroReactance() {
+        viewModel.reactance = 0
+        viewModel.circuitMode = .series
+        XCTAssertEqual(viewModel.capacitance, Double.infinity)
+    }
 
     // Testing Dissipation Factor (D)
     func testDissipationFactor() {