Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve lighthouse type definitions #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: improve lighthouse type definitions #232

wants to merge 1 commit into from

Conversation

namoscato
Copy link

@namoscato namoscato commented Oct 19, 2023 •
edited
Loading

  • add task optional callback argument
  • update command arguments from any ➡️ respective lighthouse/core types

@namoscato
fix: improve lighthouse type definitions
919fdc4 
* add task optional callback argument
* update command arguments from any -> respective lighthouse/core types
@Weeb6279
Copy link

Weeb6279 commented Mar 5, 2024

@mfrachet what is the status of this? Can this be in the next release?

@af-owe
Copy link

af-owe commented May 8, 2024 •
edited
Loading

Hey, I forked the package, fixed the typings, allowed selecting the html element with errors in pa11y and updated pa11y and lighthouse. Also extended the README, replaced the examples and published to NPM. It is now only one package for both pa11y and lighthouse. I did not want to manage multiple npm packages. But it should be explained here:

https://github.com/appsfactorygmbh/cypress-audit

npm i -D @appsfactory/cypress-audit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@namoscato @Weeb6279 @af-owe