[WIP] Log line numbers on schema validation errors #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
- Coverage 94.21% 93.52% -0.69%
==========================================
Files 21 21
Lines 2973 2998 +25
Branches 466 470 +4
==========================================
+ Hits 2801 2804 +3
- Misses 115 136 +21
- Partials 57 58 +1
☔ View full report in Codecov by Sentry. |
|
Thanks for creating the PR. I'm willing to merge. Could you just add a simple test to keep the coverage? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pr for #387. It reports the line number of schema validations exceptions to the log in addition to the message.
I still need to collect some test cases and maybe tweak the formatting.