fix: literal calls case

mgechev · Sep 26, 2023 · 6a67ee8 · 6a67ee8
1 parent 70ceb1c
commit 6a67ee8
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 1 deletion.
diff --git a/rule/unconditional-recursion.go b/rule/unconditional-recursion.go
@@ -125,7 +125,9 @@ func (w lintUnconditionalRecursionRule) Visit(node ast.Node) ast.Visitor {
 		}
 		// unconditional loop
 		return w
-	}
+	case *ast.FuncLit:
+		return nil // literal call (closure) is not an issue
+    }
 
 	return w
 }

diff --git a/testdata/unconditional-recursion.go b/testdata/unconditional-recursion.go
@@ -187,3 +187,10 @@ func (*fooType) BarFunc() {
 func (_ *fooType) BazFunc() {
 	BazFunc()
 }
+
+// Tests for #902
+func falsePositiveFuncLiteral() {
+	_ = foo(func() {
+		falsePositiveFuncLiteral()
+	})
+}