added support for usage along with UINavigationController (only tested top mode) #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Dschee sorry for the delay. I just updated the repo to version 2.0 which brings some new features and ditches the scroll view all together (still feels like a scroll view though). So, this can no longer be merged. |
|
Does version 2.0 at least support usage with UINavigationControllers? |
|
@Dschee Yes, but only opaque UI bars right now. See issue #8. There are some work arounds for transparent bars, but only for table view controllers and collection view controllers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using this classes along side with a UINavigationController in top mode and I had problems both with the NavigationController itself and with the Title Bar in iOS 7+. Therefore I put some changes to it in case that a NavigationController is apparent and iOS 7+ is used. Also I added a white background color due to some problems during Animations when NavigationController is used and didn't put a check for NavigationController for that for a more consistent look and behavior in all cases.