Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: apply igraph's stricter argument naming policy #18

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Dec 3, 2024

👋 @mhahsler! In igraph, we're adding dots between required and optional arguments as seen in https://design.tidyverse.org/dots-after-required.html The new check will pick up argument names that have been abbreviated (Note that partial matching is not recommended in the tidyverse style guide https://style.tidyverse.org/syntax.html#argument-names -- not that you have to follow this style guide in general, this comment is for context), resulting in an error.

This PR is fixing it for pomdp. Would you be able to soon make a release of your package on CRAN?

@mhahsler mhahsler merged commit b730a8c into mhahsler:master Dec 4, 2024
5 checks passed
@mhahsler
Copy link
Owner

mhahsler commented Dec 4, 2024

Thank you for this pull request. I will submit it to CRAN in the next few days.

Michael

@maelle
Copy link
Contributor Author

maelle commented Dec 10, 2024

I see the package has been updated on CRAN, thanks a lot!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants