Add support to configure the number of browser processes per instance. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies AwsVmManager in the following ways: - CHROME_THREAD_COUNT becomes non-final. - FIREFOX_IE_THREAD_COUNT becomes non final. New values are applied at runtime if the awsProperties contain keys like: - node_max_processes_chrome=8 - node_max_processes_firefox=1
mhardin
reviewed
Apr 21, 2017
| // Allow the user to override the default settings for browser | ||
| // processes per EC2 operating system instance. | ||
| String maxChromeThreads = awsProperties.getProperty("node_max_processes_chrome"); | ||
| if ((null != maxChromeThreads) && (0 != maxChromeThreads.length())) { |
There was a problem hiding this comment.
A better check is !StringUtils.isEmpty(maxChromeThreads)
|
@adam-hampton-sp are you able to add unit tests around the new logic you added? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies AwsVmManager in the following ways:
New values are applied at runtime if the awsProperties contain keys
like: