Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix write config option #7

Merged
merged 2 commits into from
Sep 20, 2024
Merged

Bugfix write config option #7

merged 2 commits into from
Sep 20, 2024

Conversation

fjclark
Copy link
Collaborator

@fjclark fjclark commented Sep 20, 2024

Description

Previously, if the user modified template_config.cfg so that there was no terminating new line, the first new config file option would be appended to the last line. This avoids the issue by checking for "\n", and adding it if required.

... at the end of the config template. This could happen if the user
manually modifies the config template and does not leave a terminating
new line.
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.90%. Comparing base (2e3e129) to head (bf0dc88).
Report is 4 commits behind head on main.

Additional details and impacted files

@fjclark fjclark merged commit 8aee7b9 into main Sep 20, 2024
5 checks passed
@fjclark fjclark deleted the bugfix_write_config_option branch November 6, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant