Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build issue with recent ffmpeg #701

Closed
wants to merge 2 commits into from

Conversation

davide125
Copy link
Contributor

@davide125 davide125 commented Feb 21, 2022

Recent versions of ffmpeg expect a const AVCodec ** type for av_find_best_stream (e.g. see https://ffmpeg.org/doxygen/trunk/group__lavf__decoding.html#ga8d4609a8f685ad894c1503ffd1b610b4). Without this change the build fails with:

src/media.cpp: In member function ‘bool FeMedia::open(const std::string&, const std::string&, sf::Texture*)’:
src/media.cpp:1066:33: error: invalid conversion from ‘AVCodec**’ to ‘const AVCodec**’ [-fpermissive]
 1066 |                         -1, -1, &dec, 0 );
      |                                 ^~~~
      |                                 |
      |                                 AVCodec**

Tested with ffmpeg 5.0 on Linux.

@mickelson
Copy link
Owner

Hi thanks, I merged your pull request here: c27312b

I'm not sure why its not showing up as merged here

@mickelson mickelson closed this Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants