feat: Label renaming and import statements #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduce the "alias" attribute for labels so that label-syncer can rename labels, rather than deleting/re-creating them. This preserves labels on existing issues and pull requests. Closes micnncim#59
This is useful when syncing labels across many projects with one config. If some projects used different label names originally, the new versions may need multiple aliases.
Now you can import labels from another file that is common to multiple projects.
GitHub will reject these labels, so we should identify them early and provide a clear message.
I am learning go!
For a large migration, it will be useful to have a dry-run to see what changes would be made before they are actually made
Doing them in parallel does not make the process much faster, but it does make the logs more difficult to read. Just do it serially instead.
…in the name The GitHub client likely needs to be fixed to properly escape label names when updating or deleting them. In the meantime, just error early and make the user rename those manually first.
|
@micnncim, I can continue using my fork indefinitely if I must, but I always prefer to contribute upstream. Please let me know if you have feedback. Thanks! |
|
Sorry for being too late. Some feedback I can give you as of now:
This would make your change easier to be merged into this project. |
|
This is a really nice feature. Any chance to merge this? |
|
I never got around to splitting this up the way the maintainer wanted. I'm lazily using a fork in my workflows: joeyparrish/[email protected] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds two main features: label renaming and import statements.
Label renaming is an extension of the work done by @larsks in PR #60. To the renaming support in #60 (
aliasfield), I added a list-of-strings field calledaliases, to better support single configs that can be used across repositories. For example, each repo could have a different existing bug label that you may to rename to unify them:The import statement further enhances our ability to share configs across repos. Common fields needed by all repos (such as
Type: bug) could be placed in a common config file. Then, each repo has its own config file with its unique labels, and the common ones get imported. For example:Finally, this makes some additional changes I found useful in testing and development:
Closes #59