Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor plugins page #13

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

vladimyr
Copy link

  • converting plugins search to ES module
  • using npm packages through snowpack
  • adding snowpack production build precommit hook using husky
  • linting micro_files using ESLint/semistandard
  • preventing lockfile generation
  • adding editorconfig

- converting plugins search to ES module
- using npm packages through `snowpack`
- adding `snowpack` production build precommit hook using `husky`
- linting micro_files using ESLint/semistandard
- preventing lockfile generation
- adding editorconfig
- removing legacy scripts from plugins page
@zyedidia
Copy link
Member

When I test this I get a "Cross-Origin Request Blocked" error. I'm a little bit concerned because this PR adds a lot of complexity and I'm not an expert in web programming.

@vladimyr
Copy link
Author

You get CORS exception on which request?
Regarding complexity, huh, what can I say web tooling is complex and there is little you can do about it. But the plugin search code itself became less complex and thus more maintainable which can be counted as a win. I've traded complexity of implementation for complexity of development setup yet this is quite comprehendable for average web dev. I understand where you are coming from but is there anyone else you can ping to check it out that has more webdev experience? 🤔

@taconi
Copy link

taconi commented Mar 23, 2024

When I test this I get a "Cross-Origin Request Blocked" error

I tested locally and had no CORS error.

I've traded complexity of implementation for complexity of development setup

Regarding this added complexity for those who are not web developers, what do you think about adding a CONTRIBUTING.md ? There would be instructions for installing the dependencies and running the project on the person's machine, so the web_modules folder serves, as a guide to basic information for other people to consult.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants