Improve website (semantics) #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes the website more semantic and adds a slight space on the header buttons.
Since the semantics are literally just the semantics, you can't see them. The header is slightly different and (in my opinion) slightly more aesthetically pleasing. If you disagree, I have left it as a separate commit for manual reverting.
Before
No header gap (and stacked sideways borders because bootstrap moments)
After
1ch header gap
Additional Info
In my opinion, if you're making multiple pages with lots of repeated stuff, you would be better off using a Static Site Generator like Hugo (if you already like it), Zola (less complex, I've seen it used for stuff like this), or Astro (more complex, likely not what you need) to make repeating stuff easier. If you switch to a tool like that, you may either want to use a GitHub action or manually build and serve the GitHub Pages from
dist/.I found some inconsistencies in the copied parts like the indented closing tags of the HTML and body for the about page. For those, you should also consider a formatter (I like Prettier).