-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LMSConfigPolish #974
base: main
Are you sure you want to change the base?
LMSConfigPolish #974
Conversation
8d8e23d
to
a268f84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not a fan of the "follow this link"
when LMS mode is active I think a button should appear next to the switch saying "Open LMS Control Panel" This button would open the LMS control panel in a new tab.
20f8660
to
22eec1c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there any way that button could look a little less haphazardly placed? I don't have any suggestions here - I know we're largely not designers - but I'd love to ensure we at least don't make things look worse. some things that I notice:
- it's a button, but doesn't do a button-like thing - it does a link-like thing
- there are two other types of buttons on the page; this is themed like neither of them
- there's zero margin/padding on this button between it and the divider - feels cramped
- it's not horizontally aligned to anything but the prior content, which feels unfinished
63885b2
to
6797c82
Compare
I'm happy to make it a link again, though we'll probably have to hash that out a little further given Klayton's dislike of my previous link strategy
Fixed
This is the case for all of the buttons, but obviated by the
I've got no good way of fixing this as there isn't really a gridmodel in place for multi-input sections but I've taken a note from the "Upload Config" section and just made there be some spacing between the inputs |
…on) and add a link to the local LMS server when LMS Mode is active Replace text link with button Re-add config download on LMSMode deactivation Correct LMS Mode link button styling to be in line with other config page buttons
6797c82
to
ab5b6d8
Compare
What does this change intend to accomplish?
Change LMS toggle switch so that it doesn't download system config on LMS deactivation, include link to LMS server when LMS Mode is active
Checklist
./scripts/test