Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the 2.8 microprofile-parent but target Java 11 #600

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

Azquelt
Copy link
Member

@Azquelt Azquelt commented Mar 18, 2024

Ensures that the TCK uses dependencies from Jakarta EE 9.1.

Keep the tck-bom at 3.2 since the only differences are to use newer versions of libraries which don't support Java 8.

Fixes #573 (follow up to #577)

Copy link
Contributor

@MikeEdgar MikeEdgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. My only suggestion is to maybe add a comment to the TCK BOM property stating the reason for the difference from the parent version.

Ensures that the TCK uses dependencies from Jakarta EE 9.1.

Keep the tck-bom at 3.2 since the only differences are to use newer
versions of libraries which don't support Java 8.
@Azquelt
Copy link
Member Author

Azquelt commented Mar 19, 2024

Yeah, that makes sense. Done.

@MikeEdgar MikeEdgar merged commit 4e6a3c7 into microprofile:main Mar 19, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MP Parent version deviates from MP Parent TCK BOM version
2 participants