Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In line editability #8057

Draft
wants to merge 30 commits into
base: main
Choose a base branch
from
Draft

In line editability #8057

wants to merge 30 commits into from

Conversation

baton17
Copy link
Contributor

@baton17 baton17 commented Nov 16, 2022

Related Issue

A Pull Request should close a single issue; multiple issues can be closed when the issues are small and related, but that should be an exception not the rule. Please keep Pull Requests small and targeted; large 'code drops' with dozens of files will be closed and asked to split into reviewable pieces. Reviews that need to be large due to dependencies will be
reviewed on a case-by-case basis.

Please use one of the well-known github fixes keywords to reference
the issue fixed with this PR (eg Fixes #). If an issue doesn't yet exist please create one to aid
in issue tracking.

NOTE: For multiple issues resolved by this PR use the corresponding keywords every time in a comma-delimited list per the reference
page above.

Description

For all Pull Requests, please describe how the issue was fixed or how the feature was implemented from a summary level. This information will be used to help provide context to the reviewers of the pull request and should be additive to the issue being closed.

Sample Card

If appropriate, please include a link to a card in one of the samples directories that can be used to validate this change. This can be an existing card or a card added with this PR.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests that were added if any. If none were added please add a quick line explaining why not.
  2. Existing relevant unit/regression tests that you ran
  3. Manual scenario verification if any; Do include .gif's or screenshots of the testing you performed here if you think that it
    will aid in code reviews or corresponding fixes on other platforms for eg.
Microsoft Reviewers: Open in CodeFlow

@ghost
Copy link

ghost commented Nov 16, 2022

Hi @baton17. Thanks for helping make the AdaptiveCards JS renderer + tooling better. As additional verification, once the JS build succeeds, please go to the test site to test out your website/designer changes.

@ghost ghost added the no-recent-activity label Nov 21, 2022
@ghost
Copy link

ghost commented Nov 21, 2022

Hi @baton17. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Nov 30, 2022
@ghost
Copy link

ghost commented Nov 30, 2022

Staleness reset by baton17

@ghost ghost added the no-recent-activity label Dec 11, 2022
@ghost
Copy link

ghost commented Dec 11, 2022

Hi @baton17. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@ghost ghost removed the no-recent-activity label Dec 13, 2022
@ghost
Copy link

ghost commented Dec 13, 2022

Staleness reset by baton17

@ghost ghost added the no-recent-activity label Dec 18, 2022
@ghost
Copy link

ghost commented Dec 18, 2022

Hi @baton17. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant