Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added host container query param to designer site #8548

Closed

Conversation

Diegorro98
Copy link

@Diegorro98 Diegorro98 commented Jun 10, 2023

Description

This PR allows to set a host container by using a query param. This query param should be a number that represents the index on CardDesigner._hostContainers array (and the index at Host App Choice Picker at the designer's UI).

To do that I created a function that checks that the index is on the valid range and then applies it.

How Verified

How you verified the fix, including one or all of the following:

  1. New unit tests that were added if any. If none were added please add a quick line explaining why not.
    No tests were added, I didn't know where are CardDesigner class tests.

I was able to test that the query param works with this url: https://adaptivecards.io/designer?hostContainerIndex=1 but I wasn't able to make work the designer because although I tried to set up the development environment with this instructions and this workaround

Microsoft Reviewers: Open in CodeFlow

@microsoft-github-policy-service
Copy link
Contributor

Hi @Diegorro98. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

1 similar comment
@microsoft-github-policy-service
Copy link
Contributor

Hi @Diegorro98. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@microsoft-github-policy-service
Copy link
Contributor

Staleness reset by anna-dingler

@microsoft-github-policy-service
Copy link
Contributor

Hi @Diegorro98. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

2 similar comments
@microsoft-github-policy-service
Copy link
Contributor

Hi @Diegorro98. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@microsoft-github-policy-service
Copy link
Contributor

Hi @Diegorro98. This pull request has had no recent activity for the past 5 days . Please take the necessary actions (review, address feedback or commit if reviewed already) to move this along.

@Diegorro98
Copy link
Author

Closing this PR because I made a new PR (#8850) with more query params.

@Diegorro98 Diegorro98 closed this Mar 11, 2024
@Diegorro98 Diegorro98 deleted the host_container_query_param branch March 11, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants