This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Add parameter to optionally send IP address #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
pezholio
force-pushed
the
optionally-send-ip-address
branch
from
7366ed1 to
6d834e6
Compare
pezholio
force-pushed
the
optionally-send-ip-address
branch
from
6d834e6 to
6663827
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In February last year, Microsoft removed logging of the IP address. In some cases this is necessary (for example, to analyse requests after a security breach, or fraud attempt), and doesn't go against GDPR, as long as the user is notified, and data is deleted after a sensible time period. There is some documentation about how to do this, but this only covers .NET
This PR adds an optional parameter to turn on IP logging, adding a
clientIPparameter to thecustomPropertiesfield in Application Insights.