Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug with KeyError: 'params/eta' #1246

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

clearhanhui
Copy link

Why are these changes needed?

Reference to #1244

Related issue number

#1244

Checks

@sonichi sonichi requested review from qingyun-wu and a team October 17, 2023 05:19
@Borda Borda changed the title Fix bug at https://github.com/microsoft/FLAML/issues/1244 Fix bug with KeyError: 'params/eta' Feb 5, 2024
@yxtay
Copy link

yxtay commented Mar 15, 2024

Any follow up on this please? The PR looks ready.

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you like to add more explainations to the docstring?

Comment on lines +30 to +32
Args:
d (dict): The target dictionary to be updated.
u (dict): A dictionary containing values to be merged into `d`.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Args:
d (dict): The target dictionary to be updated.
u (dict): A dictionary containing values to be merged into `d`.
Update the dictionary `d` with the dictionary `u` recursively.
Args:
d (dict): The target dictionary to be updated.
u (dict): A dictionary containing values to be merged into `d`.
Example:
```python
d= {'num_boost_round': 10, 'params': {'max_depth': 12, 'eta': 0.02}}
u= {'params': {'verbosity': 3, 'booster': 'gbtree'}}
recursive_update(d, u)
d # {'num_boost_round': 10, 'params': {'max_depth': 12, 'eta': 0.02, 'verbosity': 3, 'booster': 'gbtree'}}
```

Copy link
Collaborator

@thinkall thinkall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants