Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional parameter flow2 crash #966

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Animaholic
Copy link
Collaborator

@Animaholic Animaholic commented Mar 29, 2023

Added a try except block.

Related issue number

#903

Checks

Copy link
Contributor

@sonichi sonichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test to make sure this exception is raised and handled correctly?

Comment on lines +411 to +417
def test_reach(self):
search_space = {
"params": tune.choice(
[{"param": "None"}, {"param": tune.qrandint(10, 100, 10)}]
),
}
return search_space
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This only creates a search space. It won't trigger the exception.
Please make sure your test triggers the exception by testing it locally.

@qingyun-wu qingyun-wu self-assigned this Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants