Restore import/no-unresolved for ESM-only test packages #16387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
area: examples
|
AB#4614 is related. @tylerbutler do you have thoughts on if this change is appropriate for the base config? I think this import resolver is likely slightly slower than the one we're currently using (node), though I'm not sure if the difference is noticeable. |
I'm not sure. I wouldn't put it in the base config, but it might make sense to export a new config with this enabled (similar to a react config). That said, in the absence of clear benefit, I wouldn't do it. |
justus-camp
approved these changes
Aug 1, 2023
pradeepvairamani
pushed a commit
that referenced
this pull request
Aug 9, 2023
## Description #15939 and related PRs disabled this linter rule for imports to `.js` files, since the base eslint module resolver doesn't understand that relative imports to .js should sometimes conceptually refer to .ts files instead. This re-enables linting for that rule in affected packages by using [eslint-import-resolver-typescript](https://www.npmjs.com/package/eslint-import-resolver-typescript).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#15939 and related PRs disabled this linter rule for imports to
.jsfiles, since the base eslint module resolver doesn't understand that relative imports to .js should sometimes conceptually refer to .ts files instead. This re-enables linting for that rule in affected packages by using eslint-import-resolver-typescript.