Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Windows pipeline & Sync with upstream code #5

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from
Draft

Add Windows pipeline & Sync with upstream code #5

wants to merge 10 commits into from

Conversation

snnn
Copy link
Member

@snnn snnn commented Oct 22, 2024 •
edited
Loading

  1. Sync with the upstream(microsoft/onnxruntime@401d16c)
  2. Add Windows CI pipeline

@snnn snnn changed the title Add Windows pipeline Add Windows pipeline & Sync with upstream code Dec 6, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 6, 2024
View reviewed changes
include/qnbitgemm.h
PackedQuantBScale = (float*)((std::byte*)QuantBBlkSum + BlkSumSize);
QuantBBlkSum = (T*)(PackedQuantBData + PackedQuantBDataSize);
QuantBBlkSum = (T*)MlasAlignAddress(QuantBBlkSum, MlasQNBitQuantBBlkSumAlignment());
PackedQuantBScale = (T*)((std::byte*)QuantBBlkSum + BlkSumSize);

Check failure

Code scanning / CodeQL

Suspicious pointer scaling High

This pointer might have type
float
Loading
(size 4), but this pointer arithmetic is done with type byte * (size 1).
This pointer might have type
MLFloat16
Loading
(size 2), but this pointer arithmetic is done with type byte * (size 1).
src/lib/qnbitgemm.cpp

namespace
{

enum SQNBitGemmVariant {
enum QNBitGemmVariant {

Check notice

Code scanning / CodeQL

Irregular enum initialization Note

In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.
src/lib/qnbitgemm.cpp
Comment on lines +755 to +760
switch (variant) {
case SQNBitGemmVariant_BitWidth4_CompInt8:
return InitializeWorkspace_CompInt8<float>;
default:
return nullptr;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
src/lib/qnbitgemm.cpp
Comment on lines +767 to +772
switch (variant) {
case HQNBitGemmVariant_BitWidth4_CompInt8:
return InitializeWorkspace_CompInt8<MLAS_FP16>;
default:
return nullptr;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
src/lib/qnbitgemm.cpp
Comment on lines +809 to +814
switch (variant) {
case HQNBitGemmVariant_BitWidth4_CompFp16:
return HQ4BitGemm_CompFp16;
default:
return nullptr;
}

Check notice

Code scanning / CodeQL

No trivial switch statements Note

This switch statement should either handle more cases, or be rewritten as an if statement.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@snnn