Skip to content

Commit

Permalink
Merge branch 'Dev' into fix/auth-properties
Browse files Browse the repository at this point in the history
  • Loading branch information
NikCharlebois authored Feb 12, 2025
2 parents ceb1e8b + cbdbfa4 commit d49bad2
Show file tree
Hide file tree
Showing 40 changed files with 2,417 additions and 473 deletions.
34 changes: 34 additions & 0 deletions .github/workflows/Validation Checks.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
name: Validation Checks
on: [push, pull_request]

jobs:
# This workflow contains a single job called "build"
UnitTests:
# The type of runner that the job will run on
runs-on: windows-latest

permissions: write-all

# Only when run from the main repo
if: github.repository == 'microsoft/Microsoft365DSC'

# Steps represent a sequence of tasks that will be executed as part of the job
steps:
# Checks-out your repository under $GITHUB_WORKSPACE, so your job can access it
- name: Checkout Repository
uses: actions/checkout@v3

- name: Ensure No Hardcoded Graph Endpoints
shell: pwsh
run: |
$resources = Get-ChildItem './Modules/Microsoft365DSC/DSCResources/*.psm1' -Recurse
foreach ($resource in $resources)
{
$content = Get-Content $resource.FullName -Raw
$foundPosition = $content.IndexOf('https://graph.microsoft.com', 0)
if ($foundPosition -ge 0)
{
throw "Resource {$($Resource.Name)} contains hardcoded Graph references."
}
}
23 changes: 19 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,20 +2,35 @@

# UNRELEASED

* EXORetentionPolicyTag
* Initial release.
* EXOSmtpDaneInbound
* Updated authentication properties to align with MOF definition.
FIXES [#5709](https://github.com/microsoft/Microsoft365DSC/issues/5709)
* MISC
* PowerPlatform resource revamp to use direct REST API calls.
* DEPENDENCIES
* Removed dependency on Microsoft.PowerApps.Administration.PowerShell.
* Updated MSCloudLoginAssistant to version 1.1.37.

# 1.25.205.1

* AADApplication
* Refactored logic for CIM Instance evaluation in Test-TargetResource.
* AADConditionalAccessPolicy
* Changed the InsiderRiskTypes property to a string array.
* AADGroup
* AADConnectorGroupApplicationProxy
* Fixes an issue where the Get-TargetResource was not able to retrieve
instances by names.
* Refactored logic for CIM Instance evaluation in Test-TargetResource.
* AADServicePrincipal
* Fixes comparison of assigned roles for null values.
FIXES [#5717](https://github.com/microsoft/Microsoft365DSC/issues/5717)
* CommerceSelfServicePurchase
* Initial release.
* EXOSmtpDaneInbound
* Updated authentication properties to align with MOF definition.
FIXES [#5709](https://github.com/microsoft/Microsoft365DSC/issues/5709)
* SCPolicyConfig
* Fixes and issue where Get-TargetResource was returning an empty array
instead of a null value when no values were defined.
* SCRoleGroupMember
* Error handling if the Members parameter is omitted.
* MISC
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ function Get-TargetResource
if ($null -eq $getValue -and -not [string]::IsNullOrEmpty($Id))
{
Write-Verbose -Message "Could not find an Azure AD Connector Group Application Proxy with Name {$Name}"
if (-not [string]::IsNullOrEmpty($DisplayName))
if (-not [string]::IsNullOrEmpty($Name))
{
$getValue = Get-MgBetaOnPremisePublishingProfileConnectorGroup -OnPremisesPublishingProfileId 'applicationProxy' -Filter "Name eq '$Name'" -ErrorAction Stop
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ function Get-TargetResource
$Id = $getId.Id
}

$uri = 'https://graph.microsoft.com/v1.0/identityGovernance/privilegedAccess/group/eligibilitySchedules/' + $Id
$uri = "$((Get-MSCloudLoginConnectionProfile -Workload MicrosoftGraph).ResourceUrl)v1.0/identityGovernance/privilegedAccess/group/eligibilitySchedules/" + $Id
$getvalue = Invoke-GraphRequest -Uri $uri -Method Get -ErrorAction SilentlyContinue

#endregion
Expand Down
Loading

0 comments on commit d49bad2

Please sign in to comment.