Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify export of complex properties #5757

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

FabienTschanz
Copy link
Collaborator

Pull Request (PR) description

This PR updates the entire export logic of all resources:

  • Removes all calls to Update-M365DSCExportAuthenticationResults in the resources and adds it to Get-M365DSCExportContentForResource
  • Updates all logic that includes CIM instance conversion to be done inside of Microsoft365DSC and not by ReverseDSC
  • Removes all calls to Convert-DSCStringParamToVariable except for FabricAdminTenantSettings --> @NikCharlebois Can you check if it still works and / or guide me to a resolution if it doesn't?

This Pull Request (PR) fixes the following issues

  • None

Task list

  • Added an entry to the change log under the Unreleased section of the file CHANGELOG.md.
    Entry should say what was changed and how that affects users (if applicable), and
    reference the issue being resolved (if applicable).
  • Resource parameter descriptions added/updated in the schema.mof.
  • Resource documentation added/updated in README.md.
  • Resource settings.json file contains all required permissions.
  • Examples appropriately added/updated.
  • Unit tests added/updated.
  • New/changed code adheres to DSC Community Style Guidelines.

@NikCharlebois NikCharlebois merged commit 87f8f91 into microsoft:Dev Feb 12, 2025
3 checks passed
@FabienTschanz FabienTschanz deleted the feat/update-export branch February 12, 2025 12:39
@NikCharlebois
Copy link
Collaborator

@FabienTschanz let's address the Fabric setting offline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants