Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unhandled error occurs when loading a file with invalid XML forma… #438

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pontaGC
Copy link

@pontaGC pontaGC commented Feb 2, 2025

Hello,

I discovered that an unexpected error occurs when reading an empty file as the schema file in the schema dialog.
The cause of the occurrence was that XmlException was not taken into account when loading the schema file.
This is a minor improvement, as currently there is error checking when committing changes in the schema dialog.

I tested loading the invalid schema file below and verified that no unexpected errors occur (I verified that it goes through the exception path I added).

  1. empty file
  2. XSD file with unclosed XML tag
  3. XSD file opened in another process

@pontaGC
Copy link
Author

pontaGC commented Feb 2, 2025

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant