Skip to content

Commit

Permalink
fix: Make race condition between channel open and RPC less likely to …
Browse files Browse the repository at this point in the history
…occur (#5514)

Right now we rely on opening the channel to associate a ClientId with an
entry on the gateway side. This causes a race when the channel is being
opened in the background while an RPC (e.g. MyAgent.register()) is
invoked.

If the RPC is processed first, the gateway rejects it due to "invalid"
clientId.

This fix makes this condition less likely to trigger, but there is still
a piece of the puzzle that needs to be solved on the Gateway side.
  • Loading branch information
lokitoth authored Feb 12, 2025
1 parent f49f159 commit 676b611
Show file tree
Hide file tree
Showing 15 changed files with 290 additions and 275 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ jobs:

codecov:
runs-on: ubuntu-latest
needs: [test]
needs: [test, test-grpc]
strategy:
matrix:
package:
Expand Down
Loading

0 comments on commit 676b611

Please sign in to comment.