feat: [dotnet] open control channel for grpc save/load #5489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5489 +/- ##
==========================================
- Coverage 75.43% 69.12% -6.31%
==========================================
Files 171 241 +70
Lines 10465 12404 +1939
Branches 0 252 +252
==========================================
+ Hits 7894 8574 +680
- Misses 2571 3631 +1060
- Partials 0 199 +199
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
rysweet
approved these changes
Feb 18, 2025
| break; | ||
|
|
| /// <param name="context">The server call context.</param> | ||
| /// <returns>A task that represents the asynchronous operation.</returns> | ||
| /// <remarks>Control channel is used for control messages between the agent worker and the cluster.</remarks> | ||
| /// public virtual global::System.Threading.Tasks.Task OpenControlChannel(grpc::IAsyncStreamReader<global::Microsoft.AutoGen.Protobuf.ControlMessage> requestStream, grpc::IServerStreamWriter<global::Microsoft.AutoGen.Protobuf.ControlMessage> responseStream, grpc::ServerCallContext context) |
There was a problem hiding this comment.
may want to remove the commented out part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.