Skip to content

Commit

Permalink
Update scripts to use .Net 8 (#1020)
Browse files Browse the repository at this point in the history
### Motivation and Context
The projects now use .Net 8 but the scripts still reference older
versions of the SDK

### Description
Upgrade .Net version in scripts

### Contribution Checklist
- [ ] The code builds clean without any errors or warnings
- [ ] The PR follows the [Contribution
Guidelines](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md)
and the [pre-submission formatting
script](https://github.com/microsoft/chat-copilot/blob/main/CONTRIBUTING.md#development-scripts)
raises no violations
- [ ] All unit tests pass, and I have added new tests where possible
  • Loading branch information
glahaye authored Jun 19, 2024
1 parent 9eeb608 commit bdc5044
Show file tree
Hide file tree
Showing 7 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion scripts/Install.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if (!$ChocoInstalled)
}

# Ensure required packages are installed
$Packages = 'dotnet-7.0-sdk', 'nodejs', 'yarn'
$Packages = 'dotnet-8.0-sdk', 'nodejs', 'yarn'
foreach ($PackageName in $Packages)
{
choco install $PackageName -y
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/package-memorypipeline.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ param(

[string]
# .NET framework to publish.
$DotNetFramework = "net6.0",
$DotNetFramework = "net8.0",

[string]
# Target runtime to publish.
Expand Down
4 changes: 2 additions & 2 deletions scripts/deploy/package-memorypipeline.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ usage() {
echo ""
echo "Arguments:"
echo " -c, --configuration CONFIGURATION Build configuration (default: Release)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net6.0)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net8.0)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: win-x64)"
echo " -o, --output OUTPUT_DIRECTORY Output directory (default: $SCRIPT_ROOT)"
echo " -v --version VERSION Version to set files to (default: 1.0.0)"
Expand Down Expand Up @@ -68,7 +68,7 @@ done

# Set defaults
: "${CONFIGURATION:="Release"}"
: "${DOTNET:="net6.0"}"
: "${DOTNET:="net8.0"}"
: "${RUNTIME:="win-x64"}"
: "${VERSION:="1.0.0"}"
: "${INFO:=""}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/package-plugins.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ param(

[string]
# .NET framework to publish.
$DotNetFramework = "net6.0",
$DotNetFramework = "net8.0",

[string]
# Output directory for published assets.
Expand Down
4 changes: 2 additions & 2 deletions scripts/deploy/package-plugins.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ usage() {
echo ""
echo "Arguments:"
echo " -c, --configuration CONFIGURATION Build configuration (default: Release)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net6.0)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net8.0)"
echo " -o, --output OUTPUT_DIRECTORY Output directory (default: $SCRIPT_ROOT)"
echo " -v --version VERSION Version to set files to (default: 1.0.0)"
echo " -i --info INFO Additional info to put in version details"
Expand Down Expand Up @@ -62,7 +62,7 @@ done

# Set defaults
: "${CONFIGURATION:="Release"}"
: "${DOTNET:="net6.0"}"
: "${DOTNET:="net8.0"}"
: "${VERSION:="1.0.0"}"
: "${INFO:=""}"
: "${OUTPUT_DIRECTORY:="$SCRIPT_ROOT"}"
Expand Down
2 changes: 1 addition & 1 deletion scripts/deploy/package-webapi.ps1
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ param(

[string]
# .NET framework to publish.
$DotNetFramework = "net6.0",
$DotNetFramework = "net8.0",

[string]
# Target runtime to publish.
Expand Down
4 changes: 2 additions & 2 deletions scripts/deploy/package-webapi.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ usage() {
echo ""
echo "Arguments:"
echo " -c, --configuration CONFIGURATION Build configuration (default: Release)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net6.0)"
echo " -d, --dotnet DOTNET_FRAMEWORK_VERSION Target dotnet framework (default: net8.0)"
echo " -r, --runtime TARGET_RUNTIME Runtime identifier (default: win-x64)"
echo " -o, --output OUTPUT_DIRECTORY Output directory (default: $SCRIPT_ROOT)"
echo " -v --version VERSION Version to set files to (default: 1.0.0)"
Expand Down Expand Up @@ -75,7 +75,7 @@ echo "Building backend executables..."

# Set defaults
: "${CONFIGURATION:="Release"}"
: "${DOTNET:="net6.0"}"
: "${DOTNET:="net8.0"}"
: "${RUNTIME:="win-x64"}"
: "${VERSION:="0.0.0"}"
: "${INFO:=""}"
Expand Down

0 comments on commit bdc5044

Please sign in to comment.