Fix for Issue #99 #104
Merged
Fix for Issue #99 #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nds to use. bash configure script parameters updated.
github-actions
bot
added
documentation
crickman
approved these changes
Aug 3, 2023
glahaye
approved these changes
Aug 3, 2023
teresaqhoang
approved these changes
Aug 4, 2023
alliscode
approved these changes
Aug 4, 2023
teamleader-dev
pushed a commit
to vlink-group/chat-copilot
that referenced
this pull request
Oct 7, 2024
### Motivation and Context Please help reviewers and future users, providing the following information: 1. Why is this change required? Tenant Id not used if set in configure.sh, readme does not mention tenant id parameter. 2. What problem does it solve? fixes above issue 3. What scenario does it contribute to? using the local deployment scripts 4. If it fixes an open issue, please link to the issue here. microsoft#99 --> ### Description tenant id used now instead of default, if it is passed as parameter to configure.sh readme now mentions tenant id parameter + combine macos and ubunutu/debian sections so I don't have to mention tenant id (and everything else) 3 times. instead only twice. ### Contribution Checklist <!-- Before submitting this PR, please make sure: --> - [x] The code builds clean without any errors or warnings - [x] The PR follows the [Contribution Guidelines](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md) and the [pre-submission formatting script](https://github.com/microsoft/copilot-chat/blob/main/CONTRIBUTING.md#development-scripts) raises no violations - [x] All unit tests pass, and I have added new tests where possible - [x] I didn't break anyone 😄 --------- Co-authored-by: Mollie Munoz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Please help reviewers and future users, providing the following information:
-->
Description
tenant id used now instead of default, if it is passed as parameter to configure.sh
readme now mentions tenant id parameter
Contribution Checklist